Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git submodule get the wrong code #1017

Closed
yijingzeng opened this issue Sep 25, 2018 · 2 comments
Closed

git submodule get the wrong code #1017

yijingzeng opened this issue Sep 25, 2018 · 2 comments

Comments

@yijingzeng
Copy link

yijingzeng commented Sep 25, 2018 •
edited
Loading

My project includes two submodules, this file (https://github.com/argoproj/argo/blob/master/workflow/artifacts/git/git.go) only checkout the main project and do not update my submodule. I got errors in argo log because the wrong code in the submodule.
@jackfengji jackfengji mentioned this issue Oct 15, 2018
Closed
@andreimc
Copy link
Contributor

// Fixed now

@jessesuen
Copy link
Member

Fixed in #1042

icecoffee531 pushed a commit to icecoffee531/argo-workflows that referenced this issue Jan 5, 2022
@whynowy
fix(sensor-controller): Return err when a sensor spec is invalid. Fixes
f9d2cc0 
argoproj#1017 (argoproj#1018)

Signed-off-by: Derek Wang <whynowy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update submodule after checking out repo jackfengji/argo
3 participants
@andreimc @yijingzeng @jessesuen