Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ๐ŸŽธ appHistory and <Link /> can both take state #477

Merged
merged 9 commits into from
Dec 8, 2021
Merged

feat: ๐ŸŽธ appHistory and <Link /> can both take state #477

merged 9 commits into from
Dec 8, 2021

Conversation

maoxiaoke
Copy link
Collaborator

@maoxiaoke maoxiaoke commented Dec 7, 2021 •
edited
Loading

โœ… Closes: #475

@maoxiaoke maoxiaoke requested a review from ClarkXia December 7, 2021 03:56
@maoxiaoke maoxiaoke changed the base branch from master to release/2.7.0 December 7, 2021 03:56
ClarkXia
ClarkXia reviewed Dec 7, 2021
View reviewed changes
packages/icestark-app/src/util/normalizeArgs.ts Outdated
// `hashType' was relocated to the third argument.
const normalizeArgs = (state?: object | boolean, hashType?: boolean): [object, boolean] => {
if (typeof state === 'boolean') {
console.warn('[icestark]: hashType was relocated to the third argument.');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ๅปบ่ฎฎไป…ๅœจ dev ็Žฏๅขƒ่พ“ๅ‡บ

packages/icestark-app/src/appHistory.ts Outdated Show resolved Hide resolved
@maoxiaoke maoxiaoke merged commit 2f42a89 into release/2.7.0 Dec 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/history-state branch December 8, 2021 03:05
@maoxiaoke maoxiaoke mentioned this pull request Dec 8, 2021
Merged
4 tasks
maoxiaoke added a commit that referenced this pull request Dec 9, 2021
@maoxiaoke
Release: 2.7.0 (#468)
d33bf4c 
* fix: ๐Ÿ› add missing props for lifecycles (#440)
* fix: ๐Ÿ› narrow import error (#467)
* docs: โœ๏ธ upgrade vite-plugin-index-html usage (#462)
* feat: ๐ŸŽธ `appHistory` and `<Link />` can both take state (#477)
* refact/create micro app (#479)
* feat/cache css (#374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClarkXia ClarkXia ClarkXia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maoxiaoke @ClarkXia