Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/cache css #374

Merged
merged 13 commits into from
Dec 9, 2021
Merged

feat/cache css #374

merged 13 commits into from
Dec 9, 2021

Conversation

maoxiaoke
Copy link
Collaborator

Closes #373

@maoxiaoke maoxiaoke changed the title Feat/cache css [WIP]feat/cache css Sep 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the branch release/2.7.0 September 23, 2021 09:58
@maoxiaoke maoxiaoke changed the title [WIP]feat/cache css feat/cache css Nov 29, 2021
@maoxiaoke maoxiaoke changed the base branch from release/2.6.0 to master November 29, 2021 07:15
@maoxiaoke maoxiaoke changed the base branch from master to release/2.7.0 December 3, 2021 09:25
@maoxiaoke maoxiaoke requested a review from ClarkXia December 3, 2021 09:25
ClarkXia
ClarkXia requested changes Dec 6, 2021
View reviewed changes
src/apps.ts Outdated Show resolved Hide resolved
src/apps.ts Outdated Show resolved Hide resolved
src/util/handleAssets.ts Show resolved Hide resolved
@maoxiaoke maoxiaoke requested a review from ClarkXia December 8, 2021 06:05
ClarkXia
ClarkXia reviewed Dec 9, 2021
View reviewed changes
src/AppRouter.tsx
@@ -50,7 +50,6 @@ export default class AppRouter extends React.Component<AppRouterProps, AppRouter
ErrorComponent: ({ err }: { err: string | Error}) => <div>{ typeof err === 'string' ? err : err?.message }</div>,
LoadingComponent: <div>Loading...</div>,
NotFoundComponent: <div>NotFound</div>,
shouldAssetsRemove: () => true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

默认移除，确认下之前的 assets 移除逻辑是否已经兼容

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是兼容的，有默认的全局设置

@maoxiaoke maoxiaoke merged commit dcf008d into release/2.7.0 Dec 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/cache-css branch December 9, 2021 06:26
maoxiaoke added a commit that referenced this pull request Dec 9, 2021
@maoxiaoke
Release: 2.7.0 (#468)
d33bf4c 
* fix: 🐛 add missing props for lifecycles (#440)
* fix: 🐛 narrow import error (#467)
* docs: ✏️ upgrade vite-plugin-index-html usage (#462)
* feat: 🎸 `appHistory` and `<Link />` can both take state (#477)
* refact/create micro app (#479)
* feat/cache css (#374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClarkXia ClarkXia ClarkXia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maoxiaoke @ClarkXia