fix(type hints): various improvements to type hints #6862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binste
force-pushed
the
improve_type_hints
branch
from
94010bc
to
697b8f3
Compare
binste
force-pushed
the
improve_type_hints
branch
from
697b8f3
to
280ec5b
Compare
|
@binste could we partition the typehint changes per package? Like we could start typehinting |
2 tasks
|
Sounds good! See #6867 |
|
Since we're splitting the work out into smaller PRs, should we close this one for now? |
|
Sure sounds good! I'll let you close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the discussion in #6844. See the individual commits for the details but let me know if something is unclear. In 1b8d1f1 I added type hints to all attributes which are defined in
__slots__as mypy struggled to infer it for some classes and reported that the class does not have a certain attribute.Running
mypy ibis --ignore-missing-importson master:With this PR: