Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable passing mypy checks #2823

Closed
datapythonista opened this issue Jun 11, 2021 · 2 comments
Closed

chore: enable passing mypy checks #2823

datapythonista opened this issue Jun 11, 2021 · 2 comments
Labels
ci Continuous Integration issues or PRs

Comments

@datapythonista
Copy link
Contributor

We've got a mypy check in the CI, but we force it to be green, since mypy has errors.

I see that at the moment there are some issues with duplicate names of files, and mypy is not even checking or reporting errors other than that.

It'd be good to spend some time soon in fixing mypy errors, and failing the CI for mypy errors, otherwise we're adding type annotations for nothing.

@datapythonista datapythonista added ci Continuous Integration issues or PRs onboarding Issues that can be addressed by someone less familiar with ibis labels Jun 11, 2021
@cpcloud cpcloud changed the title CI: Fix mypy and validate in the CI fix: fix mypy and validate in the CI Dec 29, 2021
@cpcloud cpcloud changed the title fix: fix mypy and validate in the CI chore: fix mypy and validate in the CI Dec 29, 2021
@cpcloud cpcloud removed the onboarding Issues that can be addressed by someone less familiar with ibis label Jan 13, 2022
@cpcloud cpcloud changed the title chore: fix mypy and validate in the CI chore: enable passing mypy checks Jan 13, 2022
@cpcloud
Copy link
Member

cpcloud commented Jan 13, 2022

Over the next year or so we should make decision about whether to spend more time adding type annotations and enabling their verification in CI.

There are a number of challenges in either approach, but we should settle the issue this year.

@cpcloud cpcloud added this to the 4.0.0 milestone Apr 19, 2022
@cpcloud cpcloud removed this from the 4.0.0 milestone Jul 6, 2022
@cpcloud
Copy link
Member

cpcloud commented Jul 7, 2022

I think we're going to go about this incrementally as opposed to a mega-PR that addresses all the code in ibis and runs mypy in CI.

Feel free to submit PRs that add type annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration issues or PRs
Projects
None yet
Development

No branches or pull requests

2 participants