-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable passing mypy checks #2823
Comments
Over the next year or so we should make decision about whether to spend more time adding type annotations and enabling their verification in CI. There are a number of challenges in either approach, but we should settle the issue this year. |
I think we're going to go about this incrementally as opposed to a mega-PR that addresses all the code in ibis and runs mypy in CI. Feel free to submit PRs that add type annotations. |
We've got a mypy check in the CI, but we force it to be green, since mypy has errors.
I see that at the moment there are some issues with duplicate names of files, and mypy is not even checking or reporting errors other than that.
It'd be good to spend some time soon in fixing mypy errors, and failing the CI for mypy errors, otherwise we're adding type annotations for nothing.
The text was updated successfully, but these errors were encountered: