Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option keys cannot have more than 2 levels? #3145

Closed
gerrymanoim opened this issue Dec 7, 2021 · 5 comments · Fixed by #3151
Closed

Option keys cannot have more than 2 levels? #3145

gerrymanoim opened this issue Dec 7, 2021 · 5 comments · Fixed by #3151
Assignees
Labels
bug Incorrect behavior inside of ibis

Comments

@gerrymanoim
Copy link
Contributor

It looks like while fixing mypy issues (#2823) there was an interface change to options: c2000c2#diff-0f9cc26677da8931e7536cb28b981ad29623420291ee197ad5f4d3eaa217793aR573 such that you cannot have more than two levels.

Is this limitation necessary? We currently use a nested structure to set backend specific options.

cc @jreback

@jreback
Copy link
Contributor

jreback commented Dec 7, 2021

yep this should be reversed

@cpcloud cpcloud added bug Incorrect behavior inside of ibis regression labels Dec 8, 2021
@cpcloud
Copy link
Member

cpcloud commented Dec 8, 2021

@gerrymanoim @jreback What's the plan here? How urgent is this?

@jreback
Copy link
Contributor

jreback commented Dec 8, 2021

we are internally updating to ibis 2.0; we were substantially delayed because we needed ibis-bigquery compatibility which is now resolved. It turns out a number of things broke / unintentiallly changed during a lot of the refactorings, this is one of them.

@cpcloud
Copy link
Member

cpcloud commented Dec 8, 2021

Cool. Glad to hear y'all are updating. Happy to squash whatever bugs arise.

@gerrymanoim
Copy link
Contributor Author

@cpcloud - I'll grab this one, wanted to triage our internal stuff first and make all the open source changes at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants