Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix mypy errors in the base backend #2855

Closed
datapythonista opened this issue Jul 13, 2021 · 1 comment · Fixed by #2894
Closed

CI: Fix mypy errors in the base backend #2855

datapythonista opened this issue Jul 13, 2021 · 1 comment · Fixed by #2894
Assignees
@marcosdmyr
Labels
backends Issues related to all backends ci Continuous Integration issues or PRs onboarding Issues that can be addressed by someone less familiar with ibis

Comments

@datapythonista
Copy link
Contributor

datapythonista commented Jul 13, 2021 •
edited
Loading

xref #2823

Running mypy ibis/backends/base/ reports 18 errors, related to missing or inconsistent type annotations. We should fix them, and make that command finish in a clean way.

Here there are some sample fixes: #2857
@datapythonista datapythonista added ci Continuous Integration issues or PRs backends Issues related to all backends labels Jul 13, 2021
@datapythonista datapythonista added the onboarding Issues that can be addressed by someone less familiar with ibis label Jul 21, 2021
@marcosdmyr
Copy link

/take

@datapythonista datapythonista mentioned this issue Aug 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcosdmyr marcosdmyr

Labels
backends Issues related to all backends ci Continuous Integration issues or PRs onboarding Issues that can be addressed by someone less familiar with ibis
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mypy errors in backends/base
2 participants
@marcosdmyr @datapythonista