Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests and small syntactic improvements #2

Open
wants to merge 8 commits into
base: latest
Choose a base branch
from
Open

Add tests and small syntactic improvements #2

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
79656bd
add package-lock
alexewerlof May 3, 2019
d22f27e
remove bluebird refs
alexewerlof May 3, 2019
1eb2b41
pull out the _inflight and cleanup functions
alexewerlof May 3, 2019
ea0cef1
ignore a couple of folders
alexewerlof May 3, 2019
b15f561
install jest
alexewerlof May 3, 2019
5c2cf27
added editorconfig
alexewerlof May 3, 2019
1638ae4
moved cleanup back
alexewerlof May 3, 2019
3c25e3a
added some tests
alexewerlof May 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions inflight.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ function _inflight (unique, doFly) {
return resolve(doFly())
}))
active[unique].then(cleanup, cleanup)
function cleanup() { delete active[unique] }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other copy of cleanup() should also be removed, but really I'd prefer that you just remove this commit and 1eb2b41

}
return active[unique]
}
Expand Down