Add tests and small syntactic improvements #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iarna
requested changes
Aug 19, 2019
| @@ -13,6 +13,7 @@ function _inflight (unique, doFly) { | |||
| return resolve(doFly()) | |||
| })) | |||
| active[unique].then(cleanup, cleanup) | |||
| function cleanup() { delete active[unique] } | |||
There was a problem hiding this comment.
The other copy of cleanup() should also be removed, but really I'd prefer that you just remove this commit and 1eb2b41
| @@ -1,21 +1,14 @@ | |||
| 'use strict' | |||
| module.exports = inflight | |||
|
|
|||
| let Bluebird | |||
There was a problem hiding this comment.
Why remove this? Why not let people use bluebird if they have bluebird? Bluebird is more than a ponyfill, it also adds additional really handy APIs. Also it's often faster than native Promises.
| @@ -25,10 +25,10 @@ req('foo').then(…) | |||
| req('foo').then(…) | |||
| ``` | |||
|
|
|||
| ## SEE ALSO | |||
There was a problem hiding this comment.
I like the tests, but as a rule I use tap for my tests, not jest. Ordinarily I'm not that picky, but as I'll have to maintain this going forward, I would like to see them in tap format before landing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: The commits are atomic and can be clicked to verify the changes in each step.
package-lock.jsonto comply with modern NPMPromises are available in Node versions that are officially supportedNo functionality has changed, except removing reference to the undocumented feature of using
bluebird(which wasn't even onpackage.json).