Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Python 3.8 #71

Closed
wants to merge 3 commits into from
Closed

Handle Python 3.8 #71

wants to merge 3 commits into from

Conversation

sharevb
Copy link
Contributor

@sharevb sharevb commented Oct 25, 2023

Tested on a Python 3.8 environment, only "dict" was causing problems, replacing with Dict from typing
Fix #49

@iamleot iamleot self-assigned this Oct 25, 2023
@iamleot iamleot self-requested a review October 25, 2023 07:47
@iamleot iamleot added the bug Something isn't working label Oct 25, 2023
@sharevb
Copy link
Contributor Author

sharevb commented Nov 10, 2023

last check failing probably because of renaming of workflows ?

@sharevb
Copy link
Contributor Author

sharevb commented Nov 29, 2023

integrated dict > Dict in #72

iamleot added a commit that referenced this pull request Dec 3, 2023
Add a matrix in order to check at least:

- oldest Python version
- default Python version on pkgsrc-current
- newest Python version

Related to #49 and #71.
iamleot added a commit that referenced this pull request Dec 3, 2023
Add a matrix in order to check at least:

- oldest Python version
- default Python version on pkgsrc-current
- newest Python version

Set `fail-fast` to `false` (by default it is `true`) in order to run
all matrix jobs to see all Python versions that fail instead of
pointing out only the first (and non-deterministic) one that fails.

Related to #49 and #71.
iamleot added a commit that referenced this pull request Dec 3, 2023
Add a matrix in order to check at least:

- oldest Python version
- default Python version on pkgsrc-current
- newest Python version available

Set `fail-fast` to `false` (by default it is `true`) in order to run
all matrix jobs to see all Python versions that fail instead of
pointing out only the first (and non-deterministic) one that fails.

Related to #49 and #71.
iamleot added a commit that referenced this pull request Dec 3, 2023
Add a matrix in order to check at least:

- oldest Python version
- default Python version on pkgsrc-current
- newest Python version

Set `fail-fast` to `false` (by default it is `true`) in order to run
all matrix jobs to see all Python versions that fail instead of
pointing out only the first (and non-deterministic) one that fails.

Related to #49 and #71.
iamleot added a commit that referenced this pull request Dec 3, 2023
Python 3.8 annotations needs Dict from typing.Dict (i.e. direct `dict`
is not usable).

Switch to use it in order to be usable from all Python versions.

Related/closes #49 and #71.
iamleot added a commit that referenced this pull request Dec 3, 2023
Add a matrix in order to check at least:

- oldest Python version
- default Python version on pkgsrc-current
- newest Python version

Set `fail-fast` to `false` (by default it is `true`) in order to run
all matrix jobs to see all Python versions that fail instead of
pointing out only the first (and non-deterministic) one that fails.

Related to #49 and #71.
iamleot added a commit that referenced this pull request Dec 3, 2023
Python 3.8 annotations needs Dict from typing.Dict (i.e. direct `dict`
is not usable).

Switch to use it in order to be usable from all Python versions.

Related/closes #49 and #71.
@iamleot
Copy link
Owner

iamleot commented Dec 3, 2023

I have adjusted that a bit differently - in order to use GitHub Actions matrix instead of copypasting workflows - via #78.

Thank you!

(We can close this pull request)

@iamleot iamleot closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not compatible with 3.8
2 participants