-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not compatible with 3.8 #49
Comments
Thanks! Probably some kind of type annotation only supported in newer Python-s... I will try to investigate that! (It's tested against Python 3.10 and it should works there! (if it's not too difficult to update as a quick workaround I suggest to do that!)) I hope to investigate that better. |
Thanks for your amazingly quick answer! I tested it with 3.9 and it works flawlessly. Unfortunately, I cannot update for the moment the production server it's supposed to run on, way too touchy. |
I investigated a bit further and, not being a Python developer, that was tricky 😅 But I managed to make it work by adding an import And replacing all I cannot make a pull request with that simple solution, not tested with 3.9 or 3.10 but it woks for 3.8. And f'n thanks for that really good script. It rocks. |
Add a matrix in order to check at least: - oldest Python version - default Python version on pkgsrc-current - newest Python version Set `fail-fast` to `false` (by default it is `true`) in order to run all matrix jobs to see all Python versions that fail instead of pointing out only the first (and non-deterministic) one that fails. Related to #49 and #71.
Add a matrix in order to check at least: - oldest Python version - default Python version on pkgsrc-current - newest Python version available Set `fail-fast` to `false` (by default it is `true`) in order to run all matrix jobs to see all Python versions that fail instead of pointing out only the first (and non-deterministic) one that fails. Related to #49 and #71.
Add a matrix in order to check at least: - oldest Python version - default Python version on pkgsrc-current - newest Python version Set `fail-fast` to `false` (by default it is `true`) in order to run all matrix jobs to see all Python versions that fail instead of pointing out only the first (and non-deterministic) one that fails. Related to #49 and #71.
Add a matrix in order to check at least: - oldest Python version - default Python version on pkgsrc-current - newest Python version Set `fail-fast` to `false` (by default it is `true`) in order to run all matrix jobs to see all Python versions that fail instead of pointing out only the first (and non-deterministic) one that fails. Related to #49 and #71.
Hello,
It's apparently not compatible with versions < 3.9 anymore, contrary to what is assumed in 4f7cd22. Here's the error in 3.8:
I'm not qualified in Python to understand exactly what's going on here, as long as the
import
seems to be present at the top:from typing import Any, List, Optional, Union
.The text was updated successfully, but these errors were encountered: