Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add & update Sinhala README #1958

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Add & update Sinhala README #1958

merged 3 commits into from
Jun 22, 2022

Conversation

dinithija
Copy link
Contributor

What's in this PR?

Added sinhalese / sinhala readme for understand & read easily.

First come and first take, i like to acquire remaining space in the language line :)

Member of @HelaBasa unit, Nawala.

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1958 (21147c9) into dev (74e82b9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #1958   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          181       181           
  Lines         2064      2064           
  Branches       538       538           
=========================================
  Hits          2064      2064           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e82b9...21147c9. Read the comment docs.

@jw-foss
Copy link
Collaborator

jw-foss commented Jun 22, 2022

@dinithija Would you mind changing the title of this PR to something more specific:

"Add new language entry and README for Sinhala"

It would be much nicer for us to track the PR.

@dinithija
Copy link
Contributor Author

dinithija commented Jun 22, 2022

@jw-foss This's a basic docs related PR, you can merge right now. e.g. similar to Add Turkish README #1840
And why @iamkun seems not active? Edit: I saw you've manager role, can you enable sinhala (si) language on https://crowdin.com/project/element-plus

@jw-foss jw-foss changed the title Add & update README Add & update Sinhala README Jun 22, 2022
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@jw-foss jw-foss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment for you to consider, let me know if you have any questions

@dinithija
Copy link
Contributor Author

dinithija commented Jun 22, 2022

I left a comment for you to consider, let me know if you have any questions

Sorry, that's a mistake. fixed

@dinithija dinithija requested a review from jw-foss June 22, 2022 14:15
@jw-foss jw-foss merged commit 36662dc into iamkun:dev Jun 22, 2022
@iamkun
Copy link
Owner

iamkun commented Jul 19, 2022

🎉 This PR is included in version 1.11.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants