Missing apple emoji #153
Closed
Missing apple emoji #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Friendly ping since one of my libraries also depends on this. https://github.com/vanniktech/Emoji |
|
This is fixed in the v12 branch - see #165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what was different but on both master and #152 there were a bunch of the new images missing, looks like anything with a skin tone modifier, the pirate flag and the chess pawn. See the question marks in the apple sheets, _UNKNOWN.png files in img-apple-160, has_img_apple=false in the json etc. When I run the extract.pl script on the font file locally I do get these images generated.
Possibly an outdated font file, or possibly a missed re-run of
build_map.phpas outlined in build/apple/README.mdAnyway here are the missing apple images, new sheets, json and preview table, optimised using pngquant@2.12.2 and ImageOptim@1.8.8 on a mac.