Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Am I the only one noticing a slight decrease in quality? #356

Closed
daniele-athome opened this issue Apr 17, 2019 · 15 comments
Closed

Am I the only one noticing a slight decrease in quality? #356

daniele-athome opened this issue Apr 17, 2019 · 15 comments

Comments

@daniele-athome
Copy link

I've upgraded to 0.6.0 and noticed a decrease in image quality of the emojis. I know it's small, but it's noticeable. Maybe it's because of borders, shadows, I don't know...

Here is from commit 182e1ff:
Screenshot_1555530212

Here is from 0.6.0:
Screenshot_1555530002

Maybe something went wrong with sprites generation?

@rubengees
Copy link
Collaborator

Hmm, we have once regenareted the images in the commit 985af97.

It also updated the datasource from where we are pulling, maybe that is the cause?

@daniele-athome
Copy link
Author

daniele-athome commented Apr 17, 2019

It also updated the datasource from where we are pulling, maybe that is the cause?

I don't know... their latest release featuring EmojiOne (4.0.4) shows perfectly shaped emojis, at least for EmojiOne which I'm using now (I know they've been removed, but still...):

https://github.com/iamcal/emoji-data/raw/a97b2d2efa64535d6300660eb2cd15ecb584e79e/sheet_emojione_64.png

Anyway... other emoji sets seem to not be affected by this issue. So, since EmojiOne was removed... I guess I have to close this. :-(

@rubengees
Copy link
Collaborator

We are using 4.1.0 in version 0.6.0 I think.

@daniele-athome
Copy link
Author

We are using 4.1.0 in version 0.6.0 I think.

Wasn't EmojiOne removed already in 4.1.0?

@rubengees
Copy link
Collaborator

You are right! What I said was wrong, release 0.6.0 did use version 4.0.4. We can try to regenerate with the latest version and see how the quality is of that.

@daniele-athome
Copy link
Author

Already tried with both optimization on and off. No difference.
And the latest version doesn't have EmojiOne anyway...

I switched to iOS emojis now, which are the only ones really fine (graphic quality speaking); Google and Twitter seem somewhat blurry compared to the datasource. Maybe an investigation for those is due.

@rubengees
Copy link
Collaborator

I see, we need to look into that then. Can't think of anything right now what causes that.
I'll reopen the issue to keep track of this.

@rubengees rubengees reopened this Apr 17, 2019
@nosikuminyoi
Copy link

same issue here, ios emojis... please help

@nosikuminyoi
Copy link

@rubengees

@vanniktech
Copy link
Owner

I'll cut a new release soon. Do you want this to be part of @rubengees?

@rubengees
Copy link
Collaborator

I'd love to, but not sure how to proceed here. Our data source has not been updated properly, so we can't really update yet (our data sources always become stale :/).

We wait for at least this PR to be merged: iamcal/emoji-data#153

@vanniktech
Copy link
Owner

Would it be possible to maintain a fork of this @rubengees ?

I also want to get started with #102 again. It's the thing that annoys me the most. I always rely on the search

@rubengees
Copy link
Collaborator

rubengees commented Sep 23, 2019

Would be possible I guess, but I'm not familiar with how the emoji sheets are generated there.
I also think that a mac book is required, since the images are taken from the installed font files.

Edit: Here are instructions on how to generate: https://github.com/iamcal/emoji-data/tree/master/build
This seems to consist of a range of various scripts.

@vanniktech
Copy link
Owner

The PR was merged

@mario
Copy link
Collaborator

mario commented Apr 9, 2020

So closing this :)

@mario mario closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants