Test native fix for transformer texture remapping #5059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColinKerr
approved these changes
Feb 10, 2023
pmconne
reviewed
Feb 10, 2023
pmconne
approved these changes
Feb 13, 2023
MichaelBelousov
requested review from
a team,
calebmshafer,
wgoehrig,
bbastings,
kabentley,
hnn0003,
grigasp,
swbsi,
mdastous-bentley,
MarcBedard8 and
aruniverse
as code owners
MichaelBelousov
removed request for
a team,
kckst8,
mdastous-bentley,
aruniverse,
hnn0003,
johnnyd710,
Ellord207,
MarcBedard8,
calebmshafer,
wgoehrig,
kabentley,
grigasp,
williamkbentley,
diegoalexdiaz,
bbastings,
jchick-bentley,
paulius-valiunas,
dassaf4,
swbsi,
ben-polinsky,
GytisCepk and
saeeedtorabi
ben-polinsky
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests remapping textures in materials, which should be fixed in the below native PR.
Closes #4947
imodel-native: https://github.com/iTwin/itwinjs-core/tree/fix-transformer-texture-remapping