fix RenderingAsset::Relocate

[MichaelBelousov]

fix RenderingAsset::Relocate for use by the transformer.

sibling PR with tests: iTwin/itwinjs-core#5059
itwinjs-core: https://github.com/iTwin/itwinjs-core/tree/fix-transformer-texture-remapping

[pmconne]

@MichaelBelousov what's this waiting on?

[MichaelBelousov]

@MichaelBelousov what's this waiting on?

flaky tests (mostly https://github.com/iTwin/itwinjs-backlog/issues/560). Last attempt just failed due to what looked like arcgis test changes, but this branch was out of date so just updated it.

[MichaelBelousov]

@mdastous-bentley @eringram @DanRod1999

Both PR branches are up to date, but I am getting a new cross-platform test failure as of this morning.

--[ FAILURE: @itwin/map-layers-formats ]--------------------[ 18.19 seconds ]--

(node:16256) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)

  67 passing (476ms)
  2 failing

  1) ArcGisFeaturePBF
       should log error when readAndRender /  readFeatureInfo is called invalid response Data:
     Error: Assert: Programmer Error
      at assert (D:\vsts_a\126\s\core\bentley\src\Assert.ts:46:9)
  ...4 lines omitted...
  2) ArcGisFeatureProvider
       fetchTile should return undefined when to format defined:
     Error: Assert: Programmer Error
      at assert (D:\vsts_a\126\s\core\bentley\src\Assert.ts:46:9)
      at ArcGisFeatureProvider.fetchTile (src\ArcGisFeature\ArcGisFeatureProvider.ts:45:32)
      at Context.<anonymous> (src\test\ArcGisFeature\ArcGisFeatureProvider.test.ts:769:46)
      at processImmediate (node:internal/timers:471:21)

Any ideas why PR validation might be failing this test? Couldn't reproduce locally with this branch.

[pmconne]

@MichaelBelousov assertions only trigger if NODE_ENV=development. Do you have that set locally? We very recently started setting it for CI jobs, to catch failed assertions during tests.

[MichaelBelousov]

@MichaelBelousov assertions only trigger if NODE_ENV=development. Do you have that set locally? We very recently started setting it for CI jobs, to catch failed assertions during tests.

good point. rerunning.

[MichaelBelousov]

@pmconne you're right, now it fails.
Pulling and running on imodel02

[pmconne]

FYI PR to enable assertions during tests included fix for at least one of your failing tests.

  1) ArcGisFeatureProvider
       fetchTile should return undefined when to format defined:
     Error: Assert: Programmer Error
      at assert (D:\vsts_a\4\s\core\bentley\src\Assert.ts:46:9)
      at ArcGisFeatureProvider.fetchTile (src\ArcGisFeature\ArcGisFeatureProvider.ts:45:32)
      at Context.<anonymous> (src\test\ArcGisFeature\ArcGisFeatureProvider.test.ts:769:46)
      at processImmediate (node:internal/timers:471:21)

[MichaelBelousov]

it also fails on imodel02 locally

[MichaelBelousov]

ok I'll just try backporting that PR to imodel02 then

[MichaelBelousov]

@khanaffan @ColinKerr

Something seems broken on imodel02, any idea what could have caused this?

I'm deterministically getting on all CI platform builds and locally:

--[ FAILURE: @itwin/core-backend ]-----------------[ 2 minutes 55.4 seconds ]--

  379 passing (3m)
  1 failing

  1) ECSqlStatement
       getRow() with navigation properties and relationships:

      AssertionError: expected false to be true
      + expected - actual

      -false
      +true
      
      at /agent/_work/1/s/core/backend/src/test/ecdb/ECSqlStatement.test.ts:2298:16
      at query (src/test/ecdb/ECSqlStatement.test.ts:24:7)
      at async /agent/_work/1/s/core/backend/src/test/ecdb/ECSqlStatement.test.ts:2292:20

row is:

{
"name":"Child 1",
"parent.id":"0x1",
"parent.relClassName":"Test.ParentHasChildren",
"myParentId":"0x1",
"myParentRelClassId":"Test.ParentHasChildren"
}

where myParentRelClassId is Test.ParentHasChildren, obviously not an id64.

[khanaffan]

@RohitPtnkr1996 This PR #146 may have caused this issue.

[MichaelBelousov]

@pmconne maybe we should consider merging this since imodel02 has this issue directly, and @RohitPtnkr1996 can investigate fixing that?

[pmconne]

@RohitPtnkr1996 @khanaffan or @ColinKerr please fix or revert #146 ASAP, it will block us from producing a new addon.

[RohitPtnkr1996]

I'm looking into the failure.
I'll have it fixed soon.