Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added console warning for Table when both subRows and subComponent exist #2288

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

smmr-dn
Copy link
Contributor

@smmr-dn smmr-dn commented Oct 7, 2024

Changes

Added console warning when users pass in subRows and subComponent for the Table at the same time, mentioned in one of the comments in this PR: #2208.

Testing

Verified that the warning appears when there are both subRows and subComponent in the Table.

Docs

Added changeset

@smmr-dn smmr-dn marked this pull request as ready for review October 7, 2024 17:06
@smmr-dn smmr-dn requested a review from a team as a code owner October 7, 2024 17:06
@smmr-dn smmr-dn requested review from mayank99 and r100-stack and removed request for a team October 7, 2024 17:06
Copy link
Member

@r100-stack r100-stack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after #2288 (comment).

Copy link
Contributor

@mayank99 mayank99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I verified that the warning appears when using both subRows and subComponent.

You should also mention in the PR description how you tested it.

Also, this is a user-facing change, so I think it needs a patch changeset.

@smmr-dn
Copy link
Contributor Author

smmr-dn commented Oct 7, 2024

LGTM. I verified that the warning appears when using both subRows and subComponent.

You should also mention in the PR description how you tested it.

Also, this is a user-facing change, so I think it needs a patch changeset.

I have modified the PR description and added a changeset.

@smmr-dn smmr-dn merged commit f0b601b into main Oct 8, 2024
17 of 18 checks passed
@smmr-dn smmr-dn deleted the uyen/table-warning branch October 8, 2024 04:58
@imodeljs-admin imodeljs-admin mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants