Fixed expandable content does not work when using enableVirtualization in Table
#2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
reviewed
Aug 27, 2024
mayank99
reviewed
Aug 28, 2024
r100-stack
reviewed
Aug 28, 2024
packages/itwinui-react/src/core/Table/TableExpandableRowMemoized.tsx
Outdated
Show resolved
Hide resolved
packages/itwinui-react/src/core/Table/TableExpandableRowMemoized.tsx
Outdated
Show resolved
Hide resolved
smmr-dn
requested review from
mayank99 and
r100-stack
and removed request for
a team
…winUI into uyen/virtualization-bug
mayank99
reviewed
Sep 18, 2024
r100-stack
reviewed
Sep 18, 2024
r100-stack
reviewed
Sep 18, 2024
…winUI into uyen/virtualization-bug
r100-stack
reviewed
Sep 19, 2024
r100-stack
approved these changes
Sep 19, 2024
r100-stack
approved these changes
Sep 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When enabling virtualization using the
virtualizerfrom@tanstack/react-virtual, expandable content was reported broken since it was originally rendered with each original row, which was completely ignored by thevirtualizer. To fix this problem, the expandable content in this PR is moved to a separate component and regenerated its index. The virtualizer now is made aware of the changes in the page size when sub-components are defined. These components are rendered accordingly to their indices associated with which row they are expanded from.Testing
Confirmed that sub-components are rendered correctly when
enableVirtualizationis set to true.An e2e test is added for expandable contents in virtualized table.
Docs
Added both
patchchangesets for the bug fix and the removal ofWithCSSTransitionin sub-components.After-PR TODOs:
Tablewhen bothsubRowsandsubComponentexist #2288WithCSSTransitionnot working in sub-components (comment)