Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
similar to #1502, brought back the old Alert api, reverting the breaking change from #1247.
the following two snippets are now equivalent:
Other notes:
ButtonBase
(from make disabled buttons interactable #1461) toAlert.Action
clickableText
,clickableTextProps
andonClose
props have been brought back but are still deprecated to encourage use of new api.clickableText
is not a good api so it should be avoided.Testing
Tested in playground, and added one unit test for legacy api.
Docs
Updated old changeset and old examples in website. Didn't add legacy api example to docs, to encourage new api.
Will update migration guide.