make disabled buttons interactable #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
force-pushed
the
mayank/disabled-buttons
branch
from
00f33af to
dbdb4a2
Compare
mayank99
requested review from
gretanausedaite and
adamhock
and removed request for
a team
adamhock
approved these changes
Aug 2, 2023
| @@ -25,3 +26,5 @@ afterEach(() => { | |||
| .querySelectorAll('[data-tippy-root]') | |||
| .forEach((tippy) => tippy.remove()); | |||
| }); | |||
|
|
|||
| global.TextEncoder = TextEncoder; | |||
There was a problem hiding this comment.
Is this change related to this PR?
There was a problem hiding this comment.
yes, it's needed for the SSR test where I'm calling renderToString
Merged
This was referenced Aug 22, 2023
Merged
Merged
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Created new
<ButtonBase>component used to replace all instances of<button>. This component intercepts thedisabledprop, converts it toaria-disabledand manually disables clicks. This keeps the tooltip focusable and allows tooltips to appear. See https://css-tricks.com/making-disabled-buttons-more-inclusive/Other notes:
disabledattribute is still used on first render to make it progressively enhanced.aria-disabledis incorrect in the case of non-button elements (e.g. links), so an additionaldata-iui-disabledattribute has been added. While "disabled links" don't make sense, this serves as a safeguard in case users decide to do such weird things.iui-button-baseclass with a small reset for normalizing button styles. This caused some very minor image changes.Testing
Screen.Recording.2023-07-31.at.2.58.37.PM.mov
Screen.Recording.2023-08-01.at.2.15.19.PM.mov
Safari + VO:
Screen.Recording.2023-07-31.at.3.04.45.PM.mov
Firefox + NVDA:
Untitled.mov
^Note: These screen reader tests required focusing the button to read out the tooltip. Simply traversing to the button using the virtual cursor didn't announce the tooltip text; this might be a bug in Tooltip.
Docs
Added changesets.