Reduce size taken by grade chips in activity tables #6668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
force-pushed
the
grade-chip-margin
branch
from
9b0b342
to
ca24b65
Compare
marcospri
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6666 we added a grae column to the students activity table, which renders a grade chip component that makes rows slightly taller than they were before due to the implicit padding in table cells.
This PR adds a bit of negative margin around the grade chip to compensate for that and make rows have the same height they had before.
This is the height of a row without grade column:
This is the height when the grade chip is included, before applying the changes from this PR:
And this is how it looks with the changes from this PR:
I added the smallest possible margin, which is enough so that a single line of text in any of the other cells is taller.
Bigger margins would not make a difference here, unless the rest of the cells were empty.
I considered implementing something in frontend-shared, that allows customizing the cells padding, but I think this should do for now and we can improve on that if we find more use cases where the padding needs to be adjusted on a per-cell basis.