Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional grade column to assignment activity table #6666

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Sep 9, 2024

Display a new "Grade" column in the assignment activity table, for assignments where auto-grading has been enabled.

image

Testing steps

  1. Go to https://hypothesis.instructure.com/courses/319/assignments/7296, and log-in as the "Hypothesis 101 Teacher" teacher.
  2. Edit the assignment and enable auto-grading (default values are fine).
  3. Open the dashboard for that assignment. The table should show a new "Grade" column.

    Note the values of that column may not be displayed yet, as that depends on Calculate and expose auto grading grade on the students metrics endpoint #6664

  4. Open the dashboard for any other assignment where auto-grading was not enabled. It should not show the "Grade" column.

@acelaya acelaya force-pushed the dashboard-grade-column branch 2 times, most recently from 3858743 to 5b67028 Compare September 10, 2024 07:08
// In that case, we need to reserve less space for the first column,
// otherwise the rest overflow.
'lg:w-[60%] md:w-[45%]': index === 0 && columns.length < 5,
'lg:w-[45%] md:w-[30%]': index === 0 && columns.length >= 5,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is starting to get coupled with concrete usages of the component, so we may have to extract it from here.

@acelaya acelaya marked this pull request as ready for review September 10, 2024 07:23
Copy link
Member

@marcospri marcospri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested it together with the BE and all seems to line up.

Nothing else to add 👍

@acelaya acelaya merged commit 29b783e into main Sep 10, 2024
9 checks passed
@acelaya acelaya deleted the dashboard-grade-column branch September 10, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants