Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperstack fix react variant #216

Closed

Conversation

mpantel
Copy link
Contributor

@mpantel mpantel commented Jul 11, 2019

Hyperstack wrongly searched for development/production variant in react-rails gem using a string instead of symbol and a wrong hash argument.

barriehadfield and others added 30 commits September 8, 2018 12:05
tutorial for react component integration in hyperstack
# Conflicts:
#	CONTRIBUTING.md
#	LICENSE
#	ROADMAP.md
#	docs/docs_overview.md
#	docs/dsl-client/hyper-i18n.md
#	docs/dsl-client/hyper-spec.md
#	docs/dsl-isomorphic/hyper-policy.md
#	docs/installation/config.md
#	docs/tools/hyper-i18n.md
#	docs/tools/hyper-spec.md
#	logos/hyperloop-logo-small-pink.png
#	logos/logo1.png
#	logos/logo2.png
#	logos/logo3.png
#	readme.md
#	ruby/hyper-component/how-component-name-lookup-works.md
#	ruby/hyper-i18n/README.md
#	ruby/hyper-spec/README.md
#	ruby/hyper-state/DOCS.md
#	ruby/hyper-state/README.md
#	ruby/hyper-trace/CODE_OF_CONDUCT.md
@catmando
Copy link
Contributor

catmando commented Feb 9, 2020

@mpantel - I'm very sorry for missing this PR... I will try to get to it this week. If I forget, PLEASE ping me!

@mpantel
Copy link
Contributor Author

mpantel commented Mar 12, 2020

Thanks for noticing! Should i repack it against a more recent branch? It is an easy fix,
around these lines:

variant = Hyperstack.env.production? ? :production : :development

catmando and others added 6 commits May 16, 2020 23:00
@mpantel
Copy link
Contributor Author

mpantel commented Feb 20, 2021

merge as #354

@mpantel mpantel closed this Feb 20, 2021
@mpantel mpantel deleted the hyperstack-fix-react-variant branch March 31, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants