New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React variant wrongly being set for development build in production #349

Closed

mpantel opened this issue Feb 11, 2021 · 0 comments · Fixed by #354

Contributor

mpantel commented Feb 11, 2021

Thanks for noticing! Should i repack it against a more recent branch? It is an easy fix,
around these lines:

hyperstack/ruby/hyper-component/lib/react/react-source.rb

Line 14 in e545ae8

variant = Hyperstack.env.production? ? :production : :development

Originally posted by @mpantel in #216 (comment)

mpantel mentioned this issue

correctly set react variant in production #354

Merged

catmando closed this as completed in #354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment