fix(dropPrefix): check properly if the key is present in a table #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
requested review from
jarifibrahim and
manishrjain
as code owners
ahsanbarkati
approved these changes
Dec 21, 2020
jarifibrahim
approved these changes
Dec 21, 2020
NamanJain8
added a commit
that referenced
this pull request
Jan 6, 2021
There may be a case when the table contains [0x0000,...., 0xffff]. If we are searching for k=0x0011, we should not directly infer that k is present. It may not be present. This leads to the triggering of compaction at the time of DropPrefix which is quite expensive. This PR fixes the issue by confirming that case by searching inside the table for the prefix. (cherry picked from commit afaf022)
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Jan 17, 2023
…ermodeinc#1623) Signed-off-by: thomassong <thomassong2012@gmail.com>
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Feb 13, 2023
…ermodeinc#1623) Signed-off-by: thomassong <thomassong2012@gmail.com>
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Sep 14, 2024
…ermodeinc#1623) Signed-off-by: thomassong <thomassong2012@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be a case when the table contains [0x0000,...., 0xffff]. If we are searching for
k=0x0011, we should not directly infer that k is present. It may not be present. This leads to the triggering of compaction at the time of DropPrefix which is quite expensive.This PR fixes the issue by confirming that case by searching inside the table for the prefix.
Fix for v2.2007 in #1622
This change is