(cherry-pick) (release/v2.2007): fix(dropPrefix): check properly if the key is present in a table #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
requested review from
jarifibrahim and
manishrjain
as code owners
NamanJain8
changed the title
There may be a case when the table contains [0x0000,...., 0xffff]. If we are searching for k=0x0011, we should not directly infer that k is present. It may not be present. This leads to the triggering of compaction at the time of DropPrefix which is quite expensive. This PR fixes the issue by confirming that case by searching inside the table for the prefix. (cherry picked from commit afaf022)
NamanJain8
force-pushed
the
naman/drop-prefix-fix
branch
from
efad954 to
958056b
Compare
NamanJain8
changed the title
|
Closing this as this is not required in v2.2007. If needed we can cherry-pick it back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be a case when the table contains
[0x0000,...., 0xffff]. If we are searching fork=0x0011, we should not directly infer thatkis present. It may not be present. This leads to the triggering of compaction at the time ofDropPrefixwhich is quite expensive.This PR fixes the issue by confirming that case by searching inside the table for the prefix.
This change is