Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aries Framework JavaScript connections topic #98

Merged
merged 3 commits into from
Sep 9, 2020

Conversation

TimoGlastra
Copy link
Member

Pretty excited about this one :)

This PR adds the initial setup for the aries-framework-javascript (AFJ) backchannel with the connection operations working with both ACA-Py and .NET.

For now a slightly modified version of the framework is packaged with the backchannel because of some interoperability issues between AFJ and ACA-Py. I'll need to look a bit deeper, but I'll either make the necessary changes in AFJ or create an issue in ACA-Py.

One note: I needed to add a .dockerignore file to the aries-backchannels directory because that's where the images are build from (instead of the aries-backchannels/javascript directory). Not a big problem, but means backchannel specific parts are stored outside of the backchannel directory.


FYI @jakubkoci @karimStekelenburg @jadhavajay

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
@swcurran
Copy link
Member

swcurran commented Sep 5, 2020

w00t!!

@TimoGlastra
Copy link
Member Author

opened hyperledger/aries-cloudagent-python#711 to address interoperability issue

Copy link
Member

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ran tests.

@swcurran swcurran merged commit 6c5f546 into hyperledger:master Sep 9, 2020
@TimoGlastra
Copy link
Member Author

I'm not sure how many CI minutes the Hyperledger account has to spare, but if you would like I could set up a GitHub actions pipeline to automatically run on PRs. Would save you some time on the repetitive local test runs ;)

Matt-Spence pushed a commit to Matt-Spence/aries-agent-test-harness that referenced this pull request Jun 29, 2021
Aries Framework JavaScript connections topic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants