feat(connector-corda): containerize plugin #805
Conversation
| RUN npm i @hyperledger/cactus-cmd-api-server@${NPM_PKG_VERSION} --production | ||
|
|
||
| ENTRYPOINT ["/sbin/tini", "--"] | ||
| CMD ["node", "node_modules/@hyperledger/cactus-cmd-api-server/dist/lib/main/typescript/cmd/cactus-api.js", "filler-until-bug-794-is-fixed"] |
There was a problem hiding this comment.
@jordigiam In the meantime #794 (#795) got merged so we should no longer need the workaround dummy parameter here. If you could remove that (after having rebased onto main) and then re-test I'd be grateful. (it can be in the context/scope of any other one of the container PRs I just happened to open this one first)
There was a problem hiding this comment.
@jordigiam I forgot that the API server image I put on my branch was not yet published so you couldn't use it as a base image just yet. I published it under this tag for now (later will create it under hyperledger as well but that takes more time)
petermetz/cactus-cmd-api-server:2021-04-18-fix-quorum-contract-types
There was a problem hiding this comment.
@petermetz I'm facing this issue when I try to use your image: "npm ERR! Invalid package name "@petermetz/cactus-cmd-api-server:2021-04-18-fix-quorum-contract-type": name can only contain URL-friendly characters"
There was a problem hiding this comment.
@jordigiam petermetz/cactus-cmd-api-server:2021-04-18-fix-quorum-contract-type is the docker image tag, not an npm package name. For the npm package you'd want this: https://www.npmjs.com/package/@hyperledger/cactus-plugin-ledger-connector-corda/v/0.4.2-main.b067fdd.29
Also now that I think about it, the container image for corda will be a little different than the others because the corda connector runs in the JVM so for this one you'll need some additional customization to the cmd-api-server base image so that it has the JDK installed. Basically you'll want a combination of the cmd-api-server base image and the standalone corda connector image here: packages/cactus-plugin-ledger-connector-corda/src/main-server/Dockerfile
There was a problem hiding this comment.
@jordigiam Other thing I just remembered in addition to the comment above: You'll need to swap out tini for supervisord to be able to manage multiple processes in the container.
jordigiam
force-pushed
the
feature/containerize-corda
branch
from
0055376
to
f2441f0
Compare
jordigiam
requested review from
sfuji822,
takeutak,
jonathan-m-hamilton and
petermetz
jordigiam
force-pushed
the
feature/containerize-corda
branch
from
f2441f0
to
986201e
Compare
|
@kikoncuo Could you give me permissions to force push on this branch? |
Signed-off-by: jordigiam <jordi.giron.amezcua@accenture.com> Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com> Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
feature/containerize-corda
branch
from
986201e
to
59bfa6b
Compare
|
This PR/issue depends on:
|
|
Closing this down for now because it's for Corda v4 but we are focusing on Corda v5. |
Resolve #789
Depends on #763
Depends on #1151