Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector-corda): containerize plugin #789

Closed
jordigiam opened this issue Apr 13, 2021 · 5 comments
Closed

feat(connector-corda): containerize plugin #789

jordigiam opened this issue Apr 13, 2021 · 5 comments
Labels
Milestone

Comments

@jordigiam
Copy link

jordigiam commented Apr 13, 2021

Is your feature request related to a problem? Please describe.

Cloud has became the de-facto way of running applications on computers.
Containers are rapidly becoming (have become?) the de-facto way of running applications in the cloud.
We therefore need to make sure that Cactus is not just built and distributed as the language native artifacts (e.g. npm packages/webpack bundles) but that it's also distributed as containers.
This doesn't just mean containerizing the API server that can host the plugins, but also means containerizing each plugin individually as well OR providing a generic image of the API server that can be configured to run any and all of the available Cactus plugins on-demand.

Describe the solution you'd like

I want to be able to whisper things like this to my terminal and expect to have a fully functional connector for Ledger X up and running in a few seconds and with the config.json file mounted at the specified path/volume that gets picked up by the API server running inside the container as well.

echo "{ \"some-configuration\": 42 } " > config.json

docker run \
  --rm \
  --volume ./config.json:/opt/hyperledger/cactus/cactus-plugin-ledger-connector-corda/config.json \ 
  hyperledger/cactus-plugin-ledger-connector-corda

Acceptance criteria

  1. Dockerfile for generate de docker image with the plugin connector and the api server running.
@elenaizaguirre
Copy link
Contributor

I will continue this issue!

@petermetz petermetz modified the milestones: v0.6.0, v0.7.0 Jul 20, 2021
@elenaizaguirre elenaizaguirre removed their assignment Jul 22, 2021
@petermetz petermetz modified the milestones: v0.7.0, v0.8.0 Aug 10, 2021
@petermetz petermetz modified the milestones: v0.8.0, v0.9.0 Aug 17, 2021
@petermetz petermetz modified the milestones: v0.9.0, v0.10.0 Sep 2, 2021
@petermetz
Copy link
Contributor

petermetz commented Dec 8, 2021

@elenaizaguirre Are you still working on this? And if yes, are you working directly on Jordi's old branch (#805) or did you start a new one?

@petermetz petermetz added the enhancement New feature or request label Dec 8, 2021
@elenaizaguirre
Copy link
Contributor

@elenaizaguirre Are you still working on this? And if yes, are you working directly on Jordi's old branch (#805) or did you start a new one?

@petermetz Sorry, I completely forgot this issue. I can work on it when I finish the one I'm working on.

@elenaizaguirre elenaizaguirre self-assigned this Dec 9, 2021
@petermetz
Copy link
Contributor

@elenaizaguirre No worries, it's easy to lose track. Recently, I've been using the VSCode GitHub extension to keep track of assigned issues/old PRs and it's been much easier through that compared to the web UI so I recommend you give it a try too if you are interested.

elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Jan 12, 2022
Allow plugin-ledger-connector-corda to read privateKey from filesystem
instead of obtain it directly from corda-aiio container

Relationed with hyperledger-cacti#789

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Jan 13, 2022
Allow plugin-ledger-connector-corda to read privateKey from filesystem
instead of obtain it directly from corda-aiio container

Relationed with hyperledger-cacti#789

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Jan 14, 2022
Allow plugin-ledger-connector-corda to read privateKey from filesystem
instead of obtain it directly from corda-aiio container

Relationed with hyperledger-cacti#789

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Jan 17, 2022
Allow plugin-ledger-connector-corda to read privateKey from filesystem
instead of obtain it directly from corda-aiio container

Relationed with hyperledger-cacti#789

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
elenaizaguirre added a commit to elenaizaguirre/cactus that referenced this issue Jan 17, 2022
Allow plugin-ledger-connector-corda to read privateKey from filesystem
instead of obtain it directly from corda-aiio container

Relationed with hyperledger-cacti#789

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
petermetz pushed a commit that referenced this issue Jan 18, 2022
Allow plugin-ledger-connector-corda to read privateKey from filesystem
instead of obtain it directly from corda-aiio container

Relationed with #789

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
aldousalvarez pushed a commit to aldousalvarez/cactus that referenced this issue Jan 19, 2022
Allow plugin-ledger-connector-corda to read privateKey from filesystem
instead of obtain it directly from corda-aiio container

Relationed with hyperledger-cacti#789

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
aldousalvarez pushed a commit to aldousalvarez/cactus that referenced this issue Jan 19, 2022
Allow plugin-ledger-connector-corda to read privateKey from filesystem
instead of obtain it directly from corda-aiio container

Relationed with hyperledger-cacti#789

Signed-off-by: Elena Izaguirre <e.izaguirre.equiza@accenture.com>
Signed-off-by: aldousalvarez <aldousss.alvarez@gmail.com>
@elenaizaguirre elenaizaguirre removed their assignment Feb 3, 2022
@petermetz
Copy link
Contributor

Closing this down for now because it's for Corda v4 but we are focusing on Corda v5.

@petermetz petermetz closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants