fix(config-service): faulty shutdownHook definition in the Config-Schema #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-courtin
requested review from
jonathan-m-hamilton and
petermetz
as code owners
|
@petermetz: Can you please review / approve this PR before continuing with PR 1621 as PR 1621 needs to get this PR first to successfully execute the api-server config UTs |
takeutak
approved these changes
Dec 13, 2021
petermetz
approved these changes
Dec 13, 2021
In the config-service of the api-server the configuration value for "shutdownHook" is not getting applied due to an issue in the reducer of the newExampleConfigEnv(). The reducer is not populating the shutdownHook configuration based on a faulty Config-Schema definition for the shutdownHook where "arg" and "env" are missing. Closes: hyperledger-cacti#1648 Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
m-courtin
force-pushed
the
fix-1648-faulty-schema-definition
branch
from
879fccd
to
f74e62d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the config-service of the api-server the configuration value for
"shutdownHook" is not getting applied due to an issue in the reducer of
the newExampleConfigEnv(). The reducer is not populating the
shutdownHook configuration based on a faulty Config-Schema definition
for the shutdownHook where "arg" and "env" are missing.
This PR needs to be approved first as it is enabling PR1621 to execute the unit tests in correct way
Closes: #1648
Signed-off-by: Michael Courtin michael.courtin@accenture.com