Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config-service): faulty shutdownHook definition in the Config-Schema definition #1648

Closed
m-courtin opened this issue Dec 10, 2021 · 2 comments · Fixed by #1649
Closed

fix(config-service): faulty shutdownHook definition in the Config-Schema definition #1648

m-courtin opened this issue Dec 10, 2021 · 2 comments · Fixed by #1649
Assignees
@m-courtin
Labels
API_Server bug Something isn't working

Comments

@m-courtin
Copy link
Contributor

m-courtin commented Dec 10, 2021 •
edited
Loading

Describe the bug

In the config-service of the api-server the configuration value for "shutdownHook" is not getting applied due to an issue in the reducer of the newExampleConfigEnv(). The reducer is not populating the shutdownHook configuration based on a faulty Config-Schema definition for the shutdownHook where "arg" and "env" are missing.
@m-courtin m-courtin added the bug Something isn't working label Dec 10, 2021
@m-courtin
Copy link
Contributor Author

@petermetz: Can you please assign this issue onto my name

m-courtin added a commit to m-courtin/cactus that referenced this issue Dec 10, 2021
@m-courtin
fix: fix faulty shutdownHook definition in the Config-Schema
879fccd 
In the config-service of the api-server the configuration value for
"shutdownHook" is not getting applied due to an issue in the reducer of
the newExampleConfigEnv(). The reducer is not populating the
shutdownHook configuration based on a faulty Config-Schema definition
for the shutdownHook where "arg" and "env" are missing.

Closes: hyperledger-cacti#1648
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
@m-courtin m-courtin mentioned this issue Dec 10, 2021
Merged
@petermetz
Copy link
Contributor

@m-courtin You got it!

m-courtin added a commit to m-courtin/cactus that referenced this issue Dec 14, 2021
@m-courtin
fix: fix faulty shutdownHook definition in the Config-Schema
f74e62d 
In the config-service of the api-server the configuration value for
"shutdownHook" is not getting applied due to an issue in the reducer of
the newExampleConfigEnv(). The reducer is not populating the
shutdownHook configuration based on a faulty Config-Schema definition
for the shutdownHook where "arg" and "env" are missing.

Closes: hyperledger-cacti#1648
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
petermetz pushed a commit that referenced this issue Dec 15, 2021
@m-courtin @petermetz
fix: fix faulty shutdownHook definition in the Config-Schema
fbae2da 
In the config-service of the api-server the configuration value for
"shutdownHook" is not getting applied due to an issue in the reducer of
the newExampleConfigEnv(). The reducer is not populating the
shutdownHook configuration based on a faulty Config-Schema definition
for the shutdownHook where "arg" and "env" are missing.

Closes: #1648
Signed-off-by: Michael Courtin <michael.courtin@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-courtin m-courtin

Labels
API_Server bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(config-service): faulty shutdownHook definition in the Config-Schema m-courtin/cactus
2 participants
@petermetz @m-courtin