Fix: lint warning fix for any to unknown #1374

[yayoiukai2021]

Lint fix for batch 25/26. + No.251 and No.240 (In the same file)

Fixes #1374

[petermetz]

@yayoiukai2021

I recommend simply omitting the explicit type declaration here in order to make the linter warning go away. Using unkown in this particular case just makes the compiler fail somewhere down the line.

Suggested change

	const response: unknown = await this.getContainer().getArchive({
	const response = await this.getContainer().getArchive({

[petermetz]

@yayoiukai2021 The other thing apart from my recommended change above is the DCO: If you click on the link labeled as "Details" next to the failing check (DCO) then it should give you specific instructions on how to fix it on the command line. If you encounter any trouble with it then feel free to ask for more help ;-)

[petermetz]

@yayoiukai2021 LGTM, thank you very much!

[petermetz]

@yayoiukai2021 You will also need to import the Stream type in order to make my other suggestion work with something like this:

import { Stream } from "stream";

[petermetz]

@yayoiukai2021 I'd fix the compiler error like this:

Suggested change

	private pullContainerImage(containerNameAndTag: string): Promise<unknown[]> {
	return new Promise((resolve, reject) => {
	const docker = new Docker();
	docker.pull(containerNameAndTag, (pullError: any, stream: any) => {
	if (pullError) {
	reject(pullError);
	} else {
	docker.modem.followProgress(
	stream,
	(progressError: any, output: any[]) => {
	if (progressError) {
	reject(progressError);
	} else {
	resolve(output);
	}
	},
	);
	}
	});
	docker.pull(
	containerNameAndTag,
	(pullError: unknown, stream: unknown) => {
	if (pullError) {
	reject(pullError);
	} else {
	docker.modem.followProgress(
	stream,
	(progressError: unknown, output: unknown[]) => {
	if (progressError) {
	reject(progressError);
	} else {
	resolve(output);
	}
	},
	);
	}
	},
	);
	private pullContainerImage(containerNameAndTag: string): Promise<unknown[]> {
	return new Promise((resolve, reject) => {
	const docker = new Docker();
	docker.pull(containerNameAndTag, (pullError: unknown, stream: Stream) => {
	if (pullError) {
	reject(pullError);
	} else {
	docker.modem.followProgress(
	stream,
	(progressError: unknown, output: unknown[]) => {
	if (progressError) {
	reject(progressError);
	} else {
	resolve(output);
	}
	},
	);
	}
	});
	});
	}

[petermetz]

Closing due to inactivity, feel free to reopen as needed and then we can continue the review.