Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: 2021-09-20 linter warnings batch 25 / 26 #1374

Closed
petermetz opened this issue Sep 20, 2021 · 6 comments
Closed

style: 2021-09-20 linter warnings batch 25 / 26 #1374

petermetz opened this issue Sep 20, 2021 · 6 comments
Labels
Developer_Experience good-first-issue Good for newcomers good-first-issue-100-introductory Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Nice-to-Have vGHC-OSD Grace Hopper Conference - Open Source Day

Comments

@petermetz
Copy link
Contributor

petermetz commented Sep 20, 2021

style: 2021-09-20 linter warnings batch 25 / 26

Description

Fix the linter errors in the Fabric Test Ledger class (packages/cactus-test-tooling/src/main/typescript/fabric/fabric-test-ledger-v1.ts)

Acceptance Criteria

  1. Each linter warning is either fixed or a specific new issue is created aimed at exactly that one linter warning where applicable: If fixing a linter warning requires a larger refactoring of the codebase, then it is justifiable to break it out into it's own GH task.
  2. The pull request submitted links to all (if any) additional issues that were created for the linter warnings that did not fit in the scope of the issue.

Full List of Linter Warnings

packages/cactus-test-tooling/src/main/typescript/fabric/fabric-test-ledger-v1.ts
190:52 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
292:52 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
396:67 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
535:14 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
588:28 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
644:30 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
776:25 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
830:29 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
866:34 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
1319:15 warning Unexpected any. Specify a different type @typescript-eslint/no-explicit-any

@petermetz petermetz added good-first-issue Good for newcomers Nice-to-Have Developer_Experience Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. good-first-issue-100-introductory labels Sep 20, 2021
@yayoiukai2021
Copy link

can you add me on this one too? Thank you!

@petermetz petermetz added the vGHC-OSD Grace Hopper Conference - Open Source Day label Oct 1, 2021
@petermetz
Copy link
Contributor Author

@yayoiukai2021 Yup, assigned it just now, thank you in advance for the contribution!

@petermetz
Copy link
Contributor Author

Reassigning due to inactivity.

@anrami
Copy link

anrami commented Jun 13, 2022

i want to work on this

@petermetz petermetz assigned anrami and unassigned yayoiukai2021 Jun 13, 2022
@yayoiukai2021
Copy link

yayoiukai2021 commented Jun 13, 2022 via email

@petermetz
Copy link
Contributor Author

Closing due to the linter numbers having gone stale in the meantime.
We need to invent a better way of tracking linter warnings for future issues like this that we'll open because the line numbers are ephemeral and therefore not well suited for this.

Please see these if you'd still like to work on linter warnings that are beginner-friendly:
https://github.com/hyperledger/cacti/issues/2674
https://github.com/hyperledger/cacti/issues/2675

@petermetz petermetz closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer_Experience good-first-issue Good for newcomers good-first-issue-100-introductory Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Nice-to-Have vGHC-OSD Grace Hopper Conference - Open Source Day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants