This repository has been archived by the owner on Feb 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 734
Feature/ledger commands #15
Merged
vimmerru
merged 19 commits into
hyperledger-archives:master
from
Artemkaaas:feature/ledger-commands
Jun 2, 2017
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8d3dd88
Implemented ledger commands
Artemkaaas d6f510b
delete serializer trait
Artemkaaas 35a7910
Merge remote-tracking branch 'refs/remotes/upstream/master'
Artemkaaas 79991f6
Merged branch feature/send_pool_open_ack_after_catchup into feature/l…
Artemkaaas bcfee9d
Added integration test
Artemkaaas 4b67e5a
Deleted unwrap usage
Artemkaaas a1685e4
Correced ip
Artemkaaas bf330ad
Merge remote-tracking branch 'refs/remotes/upstream/master'
Artemkaaas c60d2e7
Fixed errors
Artemkaaas 7d1934a
Merge remote-tracking branch 'refs/remotes/upstream/master'
Artemkaaas ecc07fa
Fix error for nym request
Artemkaaas e5915c9
Added ignor for not checked tests
Artemkaaas 4a004b4
Merge remote-tracking branch 'refs/remotes/upstream/master'
Artemkaaas 791559c
Fixed error
Artemkaaas 8d291f2
Added unit tests for ledger service
Artemkaaas 266585e
Corrected tests
Artemkaaas faf0331
fix error
Artemkaaas 6c1a4dd
Merged branch feature/ledger-commands into feature/ledger-commands
Artemkaaas eea8420
Added integration tests for Ledger Api
Artemkaaas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
extern crate serde_json; | ||
|
||
use std::error; | ||
use std::io; | ||
use std::fmt; | ||
|
@@ -58,6 +60,12 @@ impl ToErrorCode for LedgerError { | |
} | ||
} | ||
|
||
impl From<serde_json::Error> for LedgerError { | ||
fn from(err: serde_json::Error) -> LedgerError { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Common mapping from json error to Ledger error looks wrong. Depend on situation it can be Common::InvalidParam or Common::InvalidState |
||
LedgerError::CryptoError(CryptoError::InvalidStructure(err.to_string())) | ||
} | ||
} | ||
|
||
#[cfg(test)] | ||
mod tests { | ||
// use super::*; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving of сlosing parenthesis of function params list to next line is bad code style. Please fix it.