This repository has been archived by the owner on Feb 29, 2024. It is now read-only.
Feature/ledger commands #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/services/ledger/mod.rs
Conflicts: src/api/ledger.rs src/commands/ledger.rs src/commands/mod.rs tests/pool.rs
Conflicts: src/services/anoncreds/issuer.rs tests/utils/anoncreds.rs tests/utils/callback.rs tests/utils/mod.rs
vimmerru
reviewed
Jun 2, 2017
| xref, | ||
| data, | ||
| role | ||
| ).map_err(|err| SovrinError::CommonError(err))) |
There was a problem hiding this comment.
Moving of сlosing parenthesis of function params list to next line is bad code style. Please fix it.
| @@ -58,6 +60,12 @@ impl ToErrorCode for LedgerError { | |||
| } | |||
| } | |||
|
|
|||
| impl From<serde_json::Error> for LedgerError { | |||
| fn from(err: serde_json::Error) -> LedgerError { | |||
There was a problem hiding this comment.
Common mapping from json error to Ledger error looks wrong. Depend on situation it can be Common::InvalidParam or Common::InvalidState
src/services/anoncreds/issuer.rs
Outdated
| @@ -72,7 +72,7 @@ impl Issuer { | |||
| info!(target: "anoncreds_service", "Issuer generate primary keys for Schema {:?} -> start", &schema); | |||
| let mut ctx = BigNumber::new_context()?; | |||
|
|
|||
| if schema.attribute_names.len() == 0 { | |||
| if schema.attr_names.len() == 0 { | |||
| return Err(CryptoError::InvalidStructure(format!("List of attribute names is required to setup claim definition"))) | |||
There was a problem hiding this comment.
Looks like we should remove CryptoError::InvalidStructure. We have exactly the same common error.
Merged
jovfer
pushed a commit
that referenced
this pull request
Jul 12, 2017
Merging master from hyperledger
dkulic
pushed a commit
to dkulic/indy-sdk
that referenced
this pull request
Aug 14, 2018
* enable settings for global configuration (EN-142) * EN-142 hyperledger-archives#2 * stabilize unit tests, small fix for EN-125 Signed-off-by: glowkey <douglas.wightman@evernym.com>
hadleym
pushed a commit
to hadleym/indy-sdk
that referenced
this pull request
Jan 23, 2019
* merges vcx-ci with evernym indy-sdk fork Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com> * accepts libindy 1.7.0~942 Signed-off-by: Ryan Marsh <ryan.marsh44@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.