feat(client, server): remove runtime cargo feature #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing the `runtime` feature flag enables code that was previously ignored by miri running without the `runtime` flag, in places that had flags like `#[cfg(all(feature = "runtime", feature = "http2"))]`
|
Woops, a few more CI hiccups than expected here. I'll try to fix them soon 😄 |
oddgrd
force-pushed
the
feat/remove-runtime-cargo-feature
branch
from
860f0f3 to
bccd03c
Compare
oddgrd
commented
Sep 4, 2022
panic on all uses of `Exec::Default` variant as there is no longer a default async runtime, and update tests that relied on the default executor
seanmonstar
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
runtimecargo feature flag.Removing tokio as a opt-in runtime means the
common::exec::Exec::Defaultvariant will always panic. This should be refactored in a follow-up PR/issue, so that the user must always provide an executor (ref discussion in review comment).Closes #2857