Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the runtime cargo feature #2857

Closed
seanmonstar opened this issue May 20, 2022 · 2 comments · Fixed by #2975
Closed

Remove the runtime cargo feature #2857

seanmonstar opened this issue May 20, 2022 · 2 comments · Fixed by #2975
Labels
C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Milestone
1.0 RC1

Comments

@seanmonstar
Copy link
Member

seanmonstar commented May 20, 2022 •
edited
Loading

With the removal of the tcp feature and the addition of the Timer trait, we no longer have need of the runtime feature.
@seanmonstar seanmonstar added E-easy Effort: easy. A task that would be a great starting point for a new contributor. C-feature Category: feature. This is adding a new feature. labels May 20, 2022
@seanmonstar seanmonstar added this to the 1.0 milestone May 20, 2022
@seanmonstar seanmonstar moved this to Blocked in hyper 1.0 Jun 15, 2022
@seanmonstar seanmonstar mentioned this issue Jun 15, 2022
Closed
@seanmonstar
Copy link
Member Author

This is blocked on the timer related issues (like #2848) being done first.

This was referenced Jun 23, 2022
Closed
Closed
@seanmonstar seanmonstar moved this from Blocked to Todo in hyper 1.0 Sep 2, 2022
@seanmonstar
Copy link
Member Author

With a Timer added, we can now delete all cfg(feature = "runtime") stuff from hyper.

@oddgrd oddgrd mentioned this issue Sep 3, 2022
Merged
@seanmonstar seanmonstar moved this from Todo to In Progress in hyper 1.0 Sep 7, 2022
Repository owner moved this from In Progress to Done in hyper 1.0 Sep 15, 2022
seanmonstar pushed a commit that referenced this issue Sep 15, 2022
@oddgrd
feat(client, server): remove runtime cargo feature (#2975)
23a5600 
- There is no longer a `runtime` feature to enable in the `Cargo.toml.`
- Forgetting to set an executor will now panic.

Closes #2857

BREAKING CHANGE: No longer need to enable a `runtime` feature. All connection builders should set an executor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
No open projects
hyper 1.0
Status: Done
Milestone
1.0 RC1
Development

Successfully merging a pull request may close this issue.

feat(client, server): remove runtime cargo feature oddgrd/hyper
1 participant
@seanmonstar