Sampler: rework handling of notes with custom length on tempo changes #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `Note::SelectedLayerInfo` was refactored to comply with your naming conventions - `Note::SelectedLayerInfo::nNoteLength` was introduced to store the length of a note once it is first rendered in the `Sampler`. Doing it at each rendering cycles causes issues on manual tempo changes. - `Sampler::handleTimelineOrTempoChange` does now also scale the part of a note/sample still left for rendering in case rendering already has begun. This is important in case of manual tempo changes for notes with user defined length. Addresses hydrogen-music#1873
theGreatWhiteShark
merged commit 531f627
into
hydrogen-music:releases/1.2
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note::SelectedLayerInfowas refactored to comply with your naming conventionsNote::SelectedLayerInfo::nNoteLengthwas introduced to store the length of a note once it is first rendered in theSampler. Doing it at each rendering cycles causes issues on manual tempo changes.Sampler::handleTimelineOrTempoChangedoes now also scale the part of a note/sample still left for rendering in case rendering already has begun. This is important in case of manual tempo changes for notes with user defined length.Addresses #1873