Rendering issues of notes with user-defined lengths #1873
Comments
|
Agree with this reasoning ADSR: changing the length of the note should effectively move the Release point, and also filtering. I guess I would recommend that before doing anything much else in |
Any volunteer? 😄 But you are right, of course. Just hoped I could implement the drumkit map stuff without large detours. But sample rendering is too important to postpone it till 1.3.0. I would start by checking/adding some unit tests. They should step on our toes if just a single frame of rendered audio is different. So we can at least check for unintended side effects while refactoring. |
|
There is another issue with the notes having custom lengths: Defining a length
and shrinking the pattern so it ends prior to the note
leaves the note length unaffected. It will ring on. I think it would feel more natural if the custom note length is truncated at the end of the pattern. |
- `Note::SelectedLayerInfo` was refactored to comply with your naming conventions - `Note::SelectedLayerInfo::nNoteLength` was introduced to store the length of a note once it is first rendered in the `Sampler`. Doing it at each rendering cycles causes issues on manual tempo changes. - `Sampler::handleTimelineOrTempoChange` does now also scale the part of a note/sample still left for rendering in case rendering already has begun. This is important in case of manual tempo changes for notes with user defined length. Addresses hydrogen-music#1873
in case a custom note length was defined and the pattern length was reduced afterwards it is now ensured that the custom length is truncated at the end of the pattern. Else, the note could ring beyond what is visually indicated to be its end. Addresses hydrogen-music#1873
custom note lengths are used to trigger the release of a note and the `Sampler` will play them back till the additional release frames are rendered. Previously, the custom length was used to stop audio rendering of a note creating a pronounced artifact. From the looks of the code it is very likely that this worked for a long time but was broken just recently. Well, happens. But should not happen again as custom note lengths are now covered by the unit tests and even a tiny tweak on the release knob for the test song should make them fail. Addresses hydrogen-music#1873
custom note lengths are used to trigger the release of a note and the `Sampler` will play them back till the additional release frames are rendered. Previously, the custom length was used to stop audio rendering of a note creating a pronounced artifact. From the looks of the code it is very likely that this worked for a long time but was broken just recently. Well, happens. But should not happen again as custom note lengths are now covered by the unit tests and even a tiny tweak on the release knob for the test song should make them fail. Addresses hydrogen-music#1873
- `Note::SelectedLayerInfo` was refactored to comply with your naming conventions - `Note::SelectedLayerInfo::nNoteLength` was introduced to store the length of a note once it is first rendered in the `Sampler`. Doing it at each rendering cycles causes issues on manual tempo changes. - `Sampler::handleTimelineOrTempoChange` does now also scale the part of a note/sample still left for rendering in case rendering already has begun. This is important in case of manual tempo changes for notes with user defined length. Addresses hydrogen-music#1873
in case a custom note length was defined and the pattern length was reduced afterwards it is now ensured that the custom length is truncated at the end of the pattern. Else, the note could ring beyond what is visually indicated to be its end. Addresses hydrogen-music#1873
custom note lengths are used to trigger the release of a note and the `Sampler` will play them back till the additional release frames are rendered. Previously, the custom length was used to stop audio rendering of a note creating a pronounced artifact. From the looks of the code it is very likely that this worked for a long time but was broken just recently. Well, happens. But should not happen again as custom note lengths are now covered by the unit tests and even a tiny tweak on the release knob for the test song should make them fail. Addresses hydrogen-music#1873
When toying with user-defined note lengths and samples provided in #1852 I came across a couple of rendering issues:
60to360) (an edge case. I admit it :D )BYPbutton in the Instrument Editor), all custom note lengths are discarded and the entire sample is played back. We could of course argue that activating the filtering and setting a non-zero resonance shouldn't be discarded either. But then the original sample should only be played back till the user-defined length and everything that follows is the result of resonance filtering.The text was updated successfully, but these errors were encountered: