-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create build service to utilize the router and move logic away from command #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this PR works on a rather large change I will first port the build command code, then refactor to use the router
Protected methods are obviously internal and don't need an annotation.
Update HydeBuildStaticSiteCommand.php
Update BuildService.php
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 770 778 +8
===========================================
Files 100 100
Lines 1996 2019 +23
===========================================
+ Hits 1996 2019 +23
Continue to review full report at Codecov.
|
caendesilva
commented
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update refactors the static site building process to handle logic in a service, to fix #169.
As part of this refactor, the build loop no longer pulls data from the collection service, instead, the route index provided by the new Router serves as the origin of truth for what files to compile.
The rebuild service has not yet been refactored.