Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the build loop to a service #169

Closed
caendesilva opened this issue Jul 4, 2022 · 0 comments · Fixed by #174
Closed

Move the build loop to a service #169

caendesilva opened this issue Jul 4, 2022 · 0 comments · Fixed by #174
Assignees

Comments

@caendesilva
Copy link
Member

I like keeping console commands light, as I think they should mainly be an easy way to access and trigger services. Think of it as the frontend to an API. Currently the main Hyde static site building process is done in the HydeBuildStaticSiteCommand, and while I managed to put a lot of the logic into traits I do still think the command class can be simplified by moving to a service, which would also use the new router.

The reason I've had everything in the command is because I did not want to lose the Symfony progress bars, but I'm rather sure that we can access those by passing the output interface to the service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant