-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/tinyman #90
Feat/tinyman #90
Conversation
- This commit also includes odd fixes for Injective's RLU cache handling - Also includes some formatting changes
# Conflicts: # src/services/wallet/wallet.controllers.ts
Co-authored-by: vic-en <31972210+vic-en@users.noreply.github.com>
Co-authored-by: vic-en <31972210+vic-en@users.noreply.github.com>
Co-authored-by: vic-en <31972210+vic-en@users.noreply.github.com>
…teway into feat/tinyman
…teway into feat/tinyman
…teway into feat/tinyman
…to feat/tinyman
async getAccountFromAddress(address: string): Promise<Account> { | ||
const path = `${walletPath}/${this._chain}`; | ||
const encryptedMnemonic: string = await fse.readFile( | ||
`${path}/${address}.json`, |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
PR update:
Pending:
|
@vic-en Steps:
Actual:
|
Pull again. I just merged with development on this pr. |
Display balance for GOBTC in request ✅ Failed to get balance for goBTC ❌ The issue is current Tokenlist is remote, and its using |
Test performed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test performed:
Test on local WSL ubuntu20.04 with hummingbot/hummingbot#6277
-
Connect successfully wallet using
Pera wallet
seed phrase, correct balance displayed -
Ran test endpoints using curl
- Status and /connectors ✅
- /network/status?chain=algorand ✅
- /wallet/add and /wallet/remove ✅
- Get balance ✅
- Get poll ✅
- Get assets ✅ response with list of assets (GOBTC there use capital letters)
- Post opt-in ✅
- Check prices ✅
- Trade {BUY,SELL} ✅
- Compare trade data from endpoint and txhash from https://algoexplorer.io/
- If not enough balance, getting error of
overspend
both client and gateway logs - If not approved
receiver error: must op-tin
, asset 123456 missing from PZLY....UPZI, after opt-in request is resolved
-
Client + Gateway: reported issue on PR6277
Note:
- Current
Tokenlist(AssetList for algorand) is using remote URL (not local file)
- Gateway connector-tokens for this connector must be added on all uppercase, sample
GOBTC
- Failed to trade with error (Trade query failed) when using pairs that cointain lowkey letters (goBTC, goETH, USDt etc.)
- Current
Merged the PR in behalf of foundation team to development and will be available on the next version 1.16.0 |
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
[ch 39263]
This pr adds the tiny man connector on top of the Algorand chain.
Tests performed by the developer:
Tips for QA testing:
Algorand generic connector - hummingbot/hummingbot#6277
PRP - https://snapshot.org/#/hbot-prp.eth/proposal/0x08a53dead66043ee8e8b0e65229a99b52be2e212a640e992eb72c9b4cd388701