Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor / connectors statuses #105

Merged

Conversation

vic-en
Copy link
Collaborator

@vic-en vic-en commented May 16, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
This pr refactors the most connector config. And also adds the chainType field in the response to the connector endpoint.

Tests performed by the developer:

  • Response from curl -s -X GET -k --key $GATEWAY_KEY --cert $GATEWAY_CERT https://localhost:15888/connectors | jq should all connector have chainType field.

Tips for QA testing:

  • Confirm that response from curl -s -X GET -k --key $GATEWAY_KEY --cert $GATEWAY_CERT https://localhost:15888/connectors | jq has chainType in every connector.

@rapcmia rapcmia requested review from fengtality, rapcmia and nikspz May 16, 2023 05:34
@vic-en vic-en changed the title refactor connectors refactor / connectors statuses May 16, 2023
Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tests performed:
    • Cloned and installed gw105, Tested with PR6277
    • Connected gateway connectors successfully
    • test /connectors endpoint and review all connectors have chainTypes
      • uniswap, "chain_type": "EVM”
      • uniswapLP, "chain_type": "EVM”
      • pangolin, "chain_type": "EVM”
      • openocean, "chain_type": "EVM”
      • quickswap, "chain_type": "EVM”
      • perp, "chain_type": "EVM”
      • sushiswap, "chain_type": "EVM”
      • traderjoe, "chain_type": "EVM”
      • definekingdoms, "chain_type": "EVM”
      • defira, "chain_type": "EVM”
      • mad_meerkat, "chain_type": "AMM”
      • vvs, "chain_type": "EVM”
      • ref, "chain_type": "NEAR”
      • pancakeswap, "chain_type": "EVM”
      • injective, "chain_type": "INJECTIVE”
      • injective_perpetual, "chain_type": "INJECTIVE”
      • xswap, "chain_type": "EVM”
      • dexalot, "chain_type": "EVM”
      • zigzag, "chain_type": "EVM”
    • Setup simple amm-arb and review profitability rates
    • Setup pureMM using CLOB connectors, review orders placed

@nikspz nikspz requested a review from cardosofede May 17, 2023 04:37
@rapcmia rapcmia merged commit abf8327 into hummingbot:development May 18, 2023
@rapcmia
Copy link
Contributor

rapcmia commented May 18, 2023

Merged to development and part of Hummingbot version 1.16.0

@vic-en vic-en mentioned this pull request May 18, 2023
2 tasks
@rapcmia rapcmia linked an issue May 22, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Refactor chain endpoint structure
4 participants