Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git LFS to AMD docker image #36016

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Add git LFS to AMD docker image #36016

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0e9a8f
Add git lfs to AMD docker image
ivarflakstad Feb 3, 2025
e527d01
Merge branch 'main' into add-git-lfs-to-amd-image
ivarflakstad Feb 3, 2025
8b8c8a9
Merge branch 'main' into add-git-lfs-to-amd-image
ivarflakstad Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docker/transformers-pytorch-amd-gpu/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@ LABEL maintainer="Hugging Face"
ARG DEBIAN_FRONTEND=noninteractive

RUN apt update && \
apt install -y --no-install-recommends git libsndfile1-dev tesseract-ocr espeak-ng python3 python3-dev python3-pip python3-dev ffmpeg && \
apt install -y --no-install-recommends git libsndfile1-dev tesseract-ocr espeak-ng python3 python3-dev python3-pip python3-dev ffmpeg git-lfs && \
apt clean && \
rm -rf /var/lib/apt/lists/*

RUN git lfs install
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in other docker files, i see

RUN apt install -y git libsndfile1-dev tesseract-ocr espeak-ng python3 python3-pip ffmpeg git-lfs
RUN git lfs install

could you double check if apt install -y git-lfs is also needed here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you ☺️

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, not sure all those are needed btw. The docker files are created initialized by another team member, and I just trust their work.

Specifically here, I only mean the git-lfs part. If you feel comfortable to have all other stuffs including in this PR, I am ok.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be correct 👌

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my bad. all libsndfile1-dev tesseract-ocr espeak-ng python3 python3-dev things are already there before this PR ...sorry


RUN python3 -m pip install --no-cache-dir --upgrade pip numpy

RUN python3 -m pip install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/rocm6.2
Expand Down