Add git LFS to AMD docker image #36016
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| @@ -8,6 +8,8 @@ RUN apt update && \ | |||
| apt clean && \ | |||
| rm -rf /var/lib/apt/lists/* | |||
|
|
|||
| RUN git lfs install | |||
There was a problem hiding this comment.
in other docker files, i see
RUN apt install -y git libsndfile1-dev tesseract-ocr espeak-ng python3 python3-pip ffmpeg git-lfs
RUN git lfs install
could you double check if apt install -y git-lfs is also needed here?
There was a problem hiding this comment.
Nice catch! Thank you
There was a problem hiding this comment.
well, not sure all those are needed btw. The docker files are created initialized by another team member, and I just trust their work.
Specifically here, I only mean the git-lfs part. If you feel comfortable to have all other stuffs including in this PR, I am ok.
There was a problem hiding this comment.
This should be correct 👌
There was a problem hiding this comment.
oh my bad. all libsndfile1-dev tesseract-ocr espeak-ng python3 python3-dev things are already there before this PR ...sorry
ivarflakstad
force-pushed
the
add-git-lfs-to-amd-image
branch
from
396c6b3 to
f0e9a8f
Compare
What does this PR do?
Adds git LFS to the AMD docker image.
Should fix this failing test