Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force the return of token type IDs #3439

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Force the return of token type IDs #3439

merged 1 commit into from
Mar 26, 2020

Conversation

LysandreJik
Copy link
Member

@LysandreJik LysandreJik commented Mar 25, 2020 •
edited
Loading

close #3313
close #3227

These two issues happen because the token_type_ids are not generated by the encode_plus method when the SQuAD and multiple choice scripts expect it. The GLUE script was patched by #3240

thomwolf
thomwolf approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@thomwolf thomwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for now

julien-c
julien-c approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve

@thomwolf thomwolf merged commit ffcffeb into master Mar 26, 2020
@thomwolf thomwolf deleted the fix-partial-encoded-returns branch March 26, 2020 08:41
@LysandreJik LysandreJik mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomwolf thomwolf thomwolf approved these changes

@julien-c julien-c julien-c approved these changes

@mfuntowicz mfuntowicz Awaiting requested review from mfuntowicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError in GLUE data tokenization with RoBERTA An Error report about pipeline
3 participants
@LysandreJik @julien-c @thomwolf