Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Bug Fix for Running Roberta on Glue #3240

Merged
merged 3 commits into from
Mar 19, 2020
Merged

Minor Bug Fix for Running Roberta on Glue #3240

merged 3 commits into from
Mar 19, 2020

Conversation

skarakulak
Copy link
Contributor

Since RobertaTokenizer does not generate return_type_ids, running Glue with Roberta throws errors. This fix overwrites the default behaviour of the tokenizers, and forces them to generate return_type_ids.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Took the liberty to directly update the style.

@LysandreJik LysandreJik merged commit b2c2c31 into huggingface:master Mar 19, 2020
@skarakulak skarakulak deleted the fix_roberta_on_glue branch March 19, 2020 16:42
jplu pushed a commit to jplu/transformers that referenced this pull request Mar 25, 2020
* added return_token_type_ids argument for tokenizers which do not generate return_type_ids by default

* fixed styling

* Style

Co-authored-by: LysandreJik <lysandre.debut@reseau.eseo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants