Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Idefics2 #30253

Merged
merged 131 commits into from
Apr 15, 2024
Merged

Add Idefics2 #30253

merged 131 commits into from
Apr 15, 2024

Conversation

amyeroberts
Copy link
Collaborator

@amyeroberts amyeroberts commented Apr 15, 2024 •
edited
Loading

What does this PR do?

Adds the Idefics 2 model into transformers

cc @VictorSanh @ArthurZucker

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

molbap and others added 30 commits March 4, 2024 15:58
@molbap
Merge pull request #9 from huggingface/update
e536f6a 
Update
@ArthurZucker
Merge branch 'main' of github.com:huggingface/new-model-addition
ef8c0fb
@amyeroberts
Initial add model additions
79277fe
@amyeroberts
Test
6c89a99
@amyeroberts
All weights loading
2e1155b
@amyeroberts
Can perform full forward pass
661b794
@amyeroberts
Local and remote the same
dd0a3d2
@amyeroberts
Matching local and remote
d124863
@amyeroberts
Fixup
7aff0b7
@amyeroberts
Idefics2Model importable; fixup docstrings
799dc71
@amyeroberts
Don't skip by default
dbebbb1
@amyeroberts
Remove deprecated use_resampler arg
465e3ed
@amyeroberts
Remove self.config
ae5b94d
@amyeroberts
DecoupledLinear takes config
7983e93
@amyeroberts
Tidy up
0a00064
@amyeroberts
Enable eager attention and tidy up
6e4ff1b
@amyeroberts
Most tests passing
1aa8f7a
@amyeroberts
Update for batch of processed images
ea4bf34
@amyeroberts
Add image processor
b6a92da
@amyeroberts
Update doc pages
0d09b95
@amyeroberts
Update conversion script
3c11158
@amyeroberts
Remove erroneous breakpoint
c6d4559
@amyeroberts
Remove accidendtal spelling change
c6275e9
@amyeroberts
Update to reflect changes on hub - make generate work
5dd0071
@amyeroberts
Fix up
015356b
@amyeroberts
Image processor tests
8c50169
@amyeroberts
Update tests
da389b8
@amyeroberts
Add a processor
e8b131d
@amyeroberts
Add a processor
2fc3ff3
@amyeroberts
Update convert script
e06740c
amyeroberts and others added 18 commits April 14, 2024 22:13
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

VictorSanh
VictorSanh approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@VictorSanh VictorSanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of sweats and iterations!!
yoohooo!

@amyeroberts amyeroberts merged commit 6b78360 into main Apr 15, 2024
22 checks passed
@amyeroberts amyeroberts deleted the add-idefics2 branch April 15, 2024 16:03
@amyeroberts amyeroberts mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorSanh VictorSanh VictorSanh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amyeroberts @HuggingFaceDocBuilderDev @VictorSanh @molbap @ArthurZucker