Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ds z3 checkpointing when stage3_gather_16bit_weights_on_model_save=False #25817

Merged
merged 2 commits into from
Aug 31, 2023
Merged

fix ds z3 checkpointing when stage3_gather_16bit_weights_on_model_save=False #25817

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cff6480
fix ds z3 checkpointing when `stage3_gather_16bit_weights_on_model_s…
pacman100 Aug 29, 2023
bf7cb03
refactoring
pacman100 Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/transformers/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2801,6 +2801,13 @@ def save_model(self, output_dir: Optional[str] = None, _internal_call: bool = Fa
" stage3_gather_16bit_weights_on_model_save=false. Saving the full checkpoint instead, use"
" zero_to_fp32.py to recover weights"
)
self._save(output_dir, state_dict={})
# remove the dummy state_dict saved above
if self.args.should_save:
for filename in [WEIGHTS_NAME, SAFE_WEIGHTS_NAME]:
file = os.path.join(output_dir, filename)
if os.path.isfile(file):
os.remove(file)
pacman100 marked this conversation as resolved.
Show resolved Hide resolved
self.model_wrapped.save_checkpoint(output_dir)

elif self.args.should_save:
Expand Down
Loading