Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ds z3 checkpointing when stage3_gather_16bit_weights_on_model_save=False #25817

Merged
merged 2 commits into from
Aug 31, 2023
Merged

fix ds z3 checkpointing when stage3_gather_16bit_weights_on_model_save=False #25817

merged 2 commits into from
Aug 31, 2023

Conversation

pacman100
Copy link
Contributor

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 29, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@pacman100 pacman100 marked this pull request as ready for review August 29, 2023 11:31
amyeroberts
amyeroberts approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

src/transformers/trainer.py Outdated Show resolved Hide resolved
muellerzr
muellerzr approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Agree with Amy on the refactor :)

@pacman100 pacman100 merged commit e95bcae into main Aug 31, 2023
21 checks passed
@pacman100 pacman100 deleted the smangrul/fix-ds-save-state branch August 31, 2023 09:47
@zjjMaiMai zjjMaiMai mentioned this pull request Sep 4, 2023
Merged
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
@pacman100 @parambharat
fix ds z3 checkpointing when `stage3_gather_16bit_weights_on_model_sa…
8f208a2 
…ve=False` (huggingface#25817)

* fix ds z3 checkpointing when  `stage3_gather_16bit_weights_on_model_save=False`

* refactoring
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
@pacman100 @blbadger
fix ds z3 checkpointing when `stage3_gather_16bit_weights_on_model_sa…
859bc02 
…ve=False` (huggingface#25817)

* fix ds z3 checkpointing when  `stage3_gather_16bit_weights_on_model_save=False`

* refactoring
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
@pacman100 @EduardoPach
fix ds z3 checkpointing when `stage3_gather_16bit_weights_on_model_sa…
39b6132 
…ve=False` (huggingface#25817)

* fix ds z3 checkpointing when  `stage3_gather_16bit_weights_on_model_save=False`

* refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muellerzr muellerzr muellerzr approved these changes

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Saving with trainer deepspeed zero3 missing config.json and tokenizer files.
4 participants
@pacman100 @HuggingFaceDocBuilderDev @muellerzr @amyeroberts